do not hoist @ember/test-helpers
#639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR emberjs/ember-test-helpers#1211 (released in v2.8.0) made `ember-source` a peerDependency of `@ember/test-helpers`. In case of `ember-keyboard` monorepo setup, package `ember-source` does not get hoisted and stay in the `test-app/node_modules` but at the same time `@ember/test-helpers` gets hoisted as well as some another version of `ember-source`. By not hoisting `@ember/test-helpers` in the `test-app` package we avoid this issue.
|
went with another solution in #665. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR emberjs/ember-test-helpers#1211 (released in v2.8.0)
made
ember-sourcea peerDependency of@ember/test-helpers.In case of
ember-keyboardmonorepo setup, packageember-sourcedoes not get hoisted and stay in the
test-app/node_modulesbut at the same time@ember/test-helpersgets hoisted as well as some another version ofember-source.By not hoisting
@ember/test-helpersin thetest-apppackage we avoid this issue.