Spring Boot 3 and JDK 21 #1001
Open
Spring Boot 3 and JDK 21 #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1001 +/- ##
============================================
- Coverage 95.56% 95.43% -0.14%
+ Complexity 1370 1355 -15
============================================
Files 81 81
Lines 4400 4381 -19
Branches 500 502 +2
============================================
- Hits 4205 4181 -24
- Misses 94 96 +2
- Partials 101 104 +3 ☔ View full report in Codecov by Sentry. |
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
33c9252
to
968d11c
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
ca557ee
to
89a82c7
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
3 times, most recently
from
8a8a67c
to
34f9608
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
2 times, most recently
from
f90d737
to
be90699
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
be90699
to
1ec11ad
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
3 times, most recently
from
756cde2
to
a271a38
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
a271a38
to
fe6979d
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
2c5e896
to
aab519c
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
3ea789c
to
d711907
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
fd67ac9
to
017dc80
Compare
|
Review looks good. Before we merge it... |
st3v0rr
reviewed
Mar 28, 2024
.github/workflows/ci.yaml
Outdated
| - KEYCLOAK_VERSION: 21.1.1 | ||
| - KEYCLOAK_VERSION: 22.0.4 | ||
| - KEYCLOAK_VERSION: 21.1.2 | ||
| - KEYCLOAK_VERSION: 22.0.5 |
There was a problem hiding this comment.
@jonasvoelcker since only the tests fail with this 22.0.5 version can you maybe give it a try with the old version?
|
As soon as the issue with keycloak 22 tests is fixed I will merge it and perform a release. |
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
fa3a107
to
2beeac1
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
0bddd75
to
1b62312
Compare
jonasvoelcker
force-pushed
the
spring-boot-jdk-update
branch
from
1b62312
to
bbfdfb9
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The OSS support for Spring Boot 2 ended in November 2023 and there are plenty of vulnerabilities which might be addressed. This change keeps compatibility to all relevant versions which were supported before and recovered the 19.0.3-legacy version as well.
Which issue this PR fixes: fixes #827 #874 #938
Special notes for your reviewer:
Breaking
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR