Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-945] Add support for import of message bundles #950

Merged
merged 11 commits into from
Mar 28, 2024

Conversation

antikalk
Copy link
Contributor

@antikalk antikalk commented Nov 27, 2023

What this PR does / why we need it:
Add Support to import localizations with config cli

Which issue this PR fixes:
fixes #945

Special notes for your reviewer:
Work in progress:

  • Tests missing
  • CHANGELOG.md and FEATURES.md not adapted yet

Just opening this to gather feedback.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: Patch coverage is 89.09091% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 95.63%. Comparing base (312b066) to head (4c19903).

Files Patch % Lines
...oak/config/service/MessageBundleImportService.java 89.18% 0 Missing and 4 partials ⚠️
...adorsys/keycloak/config/util/LocalizationUtil.java 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #950      +/-   ##
============================================
+ Coverage     95.58%   95.63%   +0.05%     
- Complexity     1353     1371      +18     
============================================
  Files            79       81       +2     
  Lines          4346     4400      +54     
  Branches        490      500      +10     
============================================
+ Hits           4154     4208      +54     
+ Misses           95       91       -4     
- Partials         97      101       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@st3v0rr
Copy link
Member

st3v0rr commented Mar 28, 2024

Looks good to me now.
Thanks a lot I will merge it and create a new release.

@st3v0rr st3v0rr merged commit 80184b2 into adorsys:main Mar 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to import localizations message bundles
2 participants