Fix: Multiple Usage of Authenticators/Conditions in Authentication Sub-Flows #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f11h
force-pushed
the
fix/auth-flow-with-multiple-executions-of-same-type
branch
from
2c06842
to
1b2de41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=========================================
Coverage 95.56% 95.57%
- Complexity 1370 1373 +3
=========================================
Files 81 81
Lines 4400 4405 +5
Branches 500 500
=========================================
+ Hits 4205 4210 +5
Misses 94 94
Partials 101 101 ☔ View full report in Codecov by Sentry. |
f11h
force-pushed
the
fix/auth-flow-with-multiple-executions-of-same-type
branch
from
1b2de41
to
89c7593
Compare
|
|
Test for KC 23.0.1 are failing: Did not modify anything in this direction - Is this a known problem? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes: fixes #978
Special notes for your reviewer:
See Linked Bug-Ticket for detailed description of the problem.
Subflow-Executions are created without special configuration and then modified according the definiton in the input file. This requires the config-tool to query keycloak for the created execution. If we have multiple executions with different configs within one subflow they could not be found distinguished.
This PR adds a filter to the repository method to return executions with corect "alias"/"configuration" which finally allows users to have sub flows with usage of same authenticators/conditions.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR