Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support realm role attributes update #991

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oriddd
Copy link

@oriddd oriddd commented Feb 21, 2024

What this PR does / why we need it:
This PR fixes a bug where attributes are being overridden instead of merged.

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR
    Managed.md was updated.

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e2af319) 95.53% compared to head (0b1856e) 95.70%.
Report is 33 commits behind head on main.

Files Patch % Lines
...sys/keycloak/config/service/RoleImportService.java 70.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #991      +/-   ##
============================================
+ Coverage     95.53%   95.70%   +0.16%     
- Complexity     1324     1367      +43     
============================================
  Files            78       80       +2     
  Lines          4279     4376      +97     
  Branches        477      494      +17     
============================================
+ Hits           4088     4188     +100     
- Misses           91       93       +2     
+ Partials        100       95       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant