crypto: clarify require("crypto').getRandomValues is Node.js specific

Refs: nodejs#41779 Refs: nodejs#41760
aduh95 · Jan 31, 2022 · dd02e9e · dd02e9e
1 parent 4fbe9e5
commit dd02e9e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/doc/api/crypto.md b/doc/api/crypto.md
@@ -4112,7 +4112,8 @@ added: v17.4.0
 * `typedArray` {Buffer|TypedArray|DataView|ArrayBuffer}
 * Returns: {Buffer|TypedArray|DataView|ArrayBuffer} Returns `typedArray`.
 
-A convenient alias for [`crypto.webcrypto.getRandomValues()`][].
+A convenient alias for [`crypto.randomFillSync()`][] that has the same signature as
+[`crypto.webcrypto.getRandomValues()`][].
 
 ### `crypto.hkdf(digest, ikm, salt, info, keylen, callback)`
 
@@ -6005,6 +6006,7 @@ See the [list of SSL OP Flags][] for details.
 [`crypto.publicEncrypt()`]: #cryptopublicencryptkey-buffer
 [`crypto.randomBytes()`]: #cryptorandombytessize-callback
 [`crypto.randomFill()`]: #cryptorandomfillbuffer-offset-size-callback
+[`crypto.randomFillSync()`]: #cryptorandomfillsyncbuffer-offset-size
 [`crypto.scrypt()`]: #cryptoscryptpassword-salt-keylen-options-callback
 [`crypto.webcrypto.getRandomValues()`]: webcrypto.md#cryptogetrandomvaluestypedarray
 [`crypto.webcrypto.subtle`]: webcrypto.md#class-subtlecrypto

diff --git a/lib/crypto.js b/lib/crypto.js
@@ -252,6 +252,10 @@ function getFipsForced() {
   return 1;
 }
 
+function getRandomValues(array) {
+  return randomFillSync(array);
+}
+
 ObjectDefineProperty(constants, 'defaultCipherList', {
   value: getOptionValue('--tls-cipher-list')
 });
@@ -303,7 +307,7 @@ ObjectDefineProperties(module.exports, {
   getRandomValues: {
     configurable: false,
     enumerable: true,
-    get() { return lazyWebCrypto().crypto.getRandomValues; },
+    get: () => getRandomValues,
     set: undefined,
   },