Ling/upgrade cms UI to 12.17 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In EPiServer.CMS.UI 12.17.0 global notification has been rewritten in React, NotificationListViewModel has been removed. There is no way to override the original Notification item click.
Not sure why, but after calling _subscriptionService.SubscribeAsync, _principalAccessor.CurrentName() becomes empty which leads to a Null exception in NotificationMessage. advanced-cms#229
LingSpb
force-pushed
the
ling/upgrade-cms-ui-to-12.17
branch
from
15fa13b
to
6a1ec86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one upgrades to 12.17.1 and simply remove the part about overriding NotificationListViewModel.prototype.gotoSelectedNotificationOrigin. Therefore the site will work, but clicking on the external-review notification will not switch to OPE mode, nor publish the event "reviews:force-review-mode"
Fixes: #229