Fallback to master language start page version #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the default router fails to route to the content we should retry with master language as the first url segment. It may happen that user has a translated page but does not have a published start page in that version. Closes #221
We will cache the preferred language in HttpContext.Items and use it instead of relying solely on IContentLanguageAccessor Closes #221
We also need a trick with start page fallback if the translated start page is not published
gregwiechec
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the default router fails to route to the content we should
retry with master language as the first url segment.
It may happen that user has a translated page but does not have
a published start page in that version.
Fallback to master start page if not published
We also need a trick with start page fallback if the translated
start page is not published
Make sure to use the language token was created in
We will cache the preferred language in HttpContext.Items and
use it instead of relying solely on IContentLanguageAccessor
Closes #221