3.5.0 Android fixes #770
Merged
3.5.0 Android fixes #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-mogilko
added
pull: under review
ags3
ivan-mogilko
force-pushed
the
ags3--androidfixes
branch
from
bc4af75
to
4de8631
Compare
ivan-mogilko
force-pushed
the
ags3--androidfixes
branch
from
f309242
to
026cfc0
Compare
|
TIL about the older NDK's support of std:: lib. What do we lose if we suggest a newer NDK? Otherwise the changes look good. |
Older devices afaik. We bumped version of NDK in either 3.4.1 or 3.5.0 to mimimal supporting what we need. This may be bumped again later, after 3.5.0, because right now that does not seem to be necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Android build. Most things are trivial, but one I'd like to note is that apparently the older NDK version we suggest building against does not have std::lround implemented, even though they support C++11 in general.
Could be related: android/ndk#82
So I went on to replace all the std::lround in our code to lround from C library.