Skip to content

Vyper has incorrect re-entrancy lock when key is empty string

Moderate severity GitHub Reviewed Published Sep 15, 2023 in vyperlang/vyper • Updated Nov 4, 2023

Package

pip vyper (pip)

Affected versions

>= 0.2.9, < 0.3.10

Patched versions

0.3.10

Description

Impact

Locks of the type @nonreentrant("") or @nonreentrant('') do not produce reentrancy checks at runtime.

@nonreentrant("") # unprotected
@external
def bar():
    pass

@nonreentrant("lock") # protected
@external
def foo():
    pass

Patches

Patched in #3605

Workarounds

The lock name should be a non-empty string.

References

Are there any links users can visit to find out more?

References

@charles-cooper charles-cooper published to vyperlang/vyper Sep 15, 2023
Published to the GitHub Advisory Database Sep 18, 2023
Reviewed Sep 18, 2023
Published by the National Vulnerability Database Sep 18, 2023
Last updated Nov 4, 2023

Severity

Moderate
5.3
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
Low
Availability
None
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:L/A:N

Weaknesses

CVE ID

CVE-2023-42441

GHSA ID

GHSA-3hg2-r75x-g69m

Source code

Credits

Checking history
See something to contribute? Suggest improvements for this vulnerability.