Skip to content

aiohttp vulnerable to Denial of Service when trying to parse malformed POST requests

High severity GitHub Reviewed Published May 2, 2024 in aio-libs/aiohttp • Updated May 3, 2024

Package

pip aiohttp (pip)

Affected versions

< 3.9.4

Patched versions

3.9.4

Description

Summary

An attacker can send a specially crafted POST (multipart/form-data) request. When the aiohttp server processes it, the server will enter an infinite loop and be unable to process any further requests.

Impact

An attacker can stop the application from serving requests after sending a single request.


For anyone needing to patch older versions of aiohttp, the minimum diff needed to resolve the issue is (located in _read_chunk_from_length()):

diff --git a/aiohttp/multipart.py b/aiohttp/multipart.py
index 227be605c..71fc2654a 100644
--- a/aiohttp/multipart.py
+++ b/aiohttp/multipart.py
@@ -338,6 +338,8 @@ class BodyPartReader:
         assert self._length is not None, "Content-Length required for chunked read"
         chunk_size = min(size, self._length - self._read_bytes)
         chunk = await self._content.read(chunk_size)
+        if self._content.at_eof():
+            self._at_eof = True
         return chunk
 
     async def _read_chunk_from_stream(self, size: int) -> bytes:

This does however introduce some very minor issues with handling form data. So, if possible, it would be recommended to also backport the changes in:
aio-libs/aiohttp@cebe526
aio-libs/aiohttp@7eecdff
aio-libs/aiohttp@f21c6f2

References

@Dreamsorcerer Dreamsorcerer published to aio-libs/aiohttp May 2, 2024
Published by the National Vulnerability Database May 2, 2024
Published to the GitHub Advisory Database May 3, 2024
Reviewed May 3, 2024
Last updated May 3, 2024

Severity

High
7.5
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
High
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

Weaknesses

CVE ID

CVE-2024-30251

GHSA ID

GHSA-5m98-qgg9-wh84

Source code

Credits

Checking history
See something to contribute? Suggest improvements for this vulnerability.