Skip to content

Authentication bypass via incorrect XML canonicalization and DOM traversal in saml2-js

Moderate severity GitHub Reviewed Published Jul 5, 2019 to the GitHub Advisory Database • Updated Jan 9, 2023

Package

npm saml2-js (npm)

Affected versions

< 1.12.4
>= 2.0.0, < 2.0.2

Patched versions

1.12.4
2.0.2

Description

Versions of saml2-js prior to 1.12.4 or 2.0.2 are vulnerable to authentication bypass.

The saml2-js library may incorrectly utilize the results of XML DOM traversal and canonicalization APIs in such a way that an attacker may be able to manipulate the SAML data without invalidating the cryptographic signature, allowing the attack to potentially bypass authentication to SAML service providers.

Security Assertion Markup Language (SAML) is an XML-based markup language for security assertions regarding authentication and permissions, most commonly used for single sign-on (SSO) services.

Some XML DOM traversal and canonicalization APIs may be inconsistent in handling of comments within XML nodes. Incorrect use of these APIs by some SAML libraries results in incorrect parsing of the inner text of XML nodes such that any inner text after the comment is lost prior to cryptographically signing the SAML message. Text after the comment therefore has no impact on the signature on the SAML message.

A remote attacker can modify SAML content for a SAML service provider without invalidating the cryptographic signature, which may allow attackers to bypass primary authentication for the affected SAML service provider

Recommendation

If you use 1.x upgrade to version 1.12.4 or greater
If you use 2.x upgrade to version 2.02 or greater

References

Published to the GitHub Advisory Database Jul 5, 2019
Reviewed Jun 16, 2020
Last updated Jan 9, 2023

Severity

Moderate

Weaknesses

CVE ID

CVE-2017-11429

GHSA ID

GHSA-5p5w-j3g7-w4wv

Source code

No known source code
Checking history
See something to contribute? Suggest improvements for this vulnerability.