Skip to content

Uncontrolled Resource Consumption in promhttp

High severity GitHub Reviewed Published Feb 15, 2022 in prometheus/client_golang • Updated Feb 15, 2023

Package

gomod github.com/prometheus/client_golang (Go)

Affected versions

< 1.11.1

Patched versions

1.11.1

Description

This is the Go client library for Prometheus. It has two separate parts, one for instrumenting application code, and one for creating clients that talk to the Prometheus HTTP API. client_golang is the instrumentation library for Go applications in Prometheus, and the promhttp package in client_golang provides tooling around HTTP servers and clients.

Impact

HTTP server susceptible to a Denial of Service through unbounded cardinality, and potential memory exhaustion, when handling requests with non-standard HTTP methods.

Affected Configuration

In order to be affected, an instrumented software must

  • Use any of promhttp.InstrumentHandler* middleware except RequestsInFlight.
  • Do not filter any specific methods (e.g GET) before middleware.
  • Pass metric with method label name to our middleware.
  • Not have any firewall/LB/proxy that filters away requests with unknown method.

Patches

Workarounds

If you cannot upgrade to v1.11.1 or above, in order to stop being affected you can:

  • Remove method label name from counter/gauge you use in the InstrumentHandler.
  • Turn off affected promhttp handlers.
  • Add custom middleware before promhttp handler that will sanitize the request method given by Go http.Request.
  • Use a reverse proxy or web application firewall, configured to only allow a limited set of methods.

For more information

If you have any questions or comments about this advisory:

References

@bwplotka bwplotka published to prometheus/client_golang Feb 15, 2022
Published by the National Vulnerability Database Feb 15, 2022
Published to the GitHub Advisory Database Feb 16, 2022
Reviewed Feb 16, 2022
Last updated Feb 15, 2023

Severity

High
7.5
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
None
User interaction
None
Scope
Unchanged
Confidentiality
None
Integrity
None
Availability
High
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H

CVE ID

CVE-2022-21698

GHSA ID

GHSA-cg3q-j54f-5p7p

Credits

Checking history
See something to contribute? Suggest improvements for this vulnerability.