Skip to content

Twisted vulnerable to NameVirtualHost Host header injection

Moderate severity GitHub Reviewed Published Oct 26, 2022 in twisted/twisted • Updated Jan 27, 2023

Package

pip twisted (pip)

Affected versions

>= 0.9.4, < 22.10.0rc1

Patched versions

22.10.0rc1

Description

When the host header does not match a configured host, twisted.web.vhost.NameVirtualHost will return a NoResource resource which renders the Host header unescaped into the 404 response allowing HTML and script injection.

Example configuration:

from twisted.web.server import Site
from twisted.web.vhost import NameVirtualHost
from twisted.internet import reactor

resource = NameVirtualHost()
site = Site(resource)
reactor.listenTCP(8080, site)
reactor.run()

Output:

❯ curl -H"Host:<h1>HELLO THERE</h1>" http://localhost:8080/

<html>
  <head><title>404 - No Such Resource</title></head>
  <body>
    <h1>No Such Resource</h1>
    <p>host b'<h1>hello there</h1>' not in vhost map</p>
  </body>
</html>

This vulnerability was introduced in f49041bb67792506d85aeda9cf6157e92f8048f4 and first appeared in the 0.9.4 release.

References

@adiroiban adiroiban published to twisted/twisted Oct 26, 2022
Published by the National Vulnerability Database Oct 26, 2022
Published to the GitHub Advisory Database Oct 26, 2022
Reviewed Oct 26, 2022
Last updated Jan 27, 2023

Severity

Moderate
5.4
/ 10

CVSS base metrics

Attack vector
Network
Attack complexity
Low
Privileges required
Low
User interaction
Required
Scope
Changed
Confidentiality
Low
Integrity
Low
Availability
None
CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:N

CVE ID

CVE-2022-39348

GHSA ID

GHSA-vg46-2rrj-3647

Source code

Credits

Checking history
See something to contribute? Suggest improvements for this vulnerability.