Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nuxt version #2524

Closed
wants to merge 1 commit into from
Closed

Bump nuxt version #2524

wants to merge 1 commit into from

Conversation

apiweb
Copy link

@apiweb apiweb commented Jan 18, 2024

I create this pull request to update the Nuxt version in the AudioBookShelf repo from v2.15.8 to v2.17.3.
When I tried setting up my environment locally and ran npm run in the client folder, I hit an error:

Screenshot 2024-01-18 at 08 57 04

To fix this I need to put some code on package.json

Screenshot 2024-01-18 at 08 55 27

It looks like there's a bug related to the crypto node library. Nuxt fixed this in version v2.16.2, but AudioBookShelf is currently on v2.15.8. So, I decided to jump to the latest, v2.17.3.

I dug into the Breaking Changes between v2.15.8 and v2.17.3. The only one I found was in the upgrade to 2.16.0, which was about a new postcss options format. You can get all the details here.

After updating the nuxt.config.js file, I tested the app locally. Everything seemed fine - no errors while navigating pages, and both npm run build and npm run generate worked without a hitch.

@advplyr
Copy link
Owner

advplyr commented Jan 18, 2024

What version of node are you using? I'm still on v16.14.0 and think that may need to be updated first. I planned to jump to node 20

@apiweb
Copy link
Author

apiweb commented Jan 18, 2024

Oh, my bad. I'm in Node 18, I was on Node 16, but a few weeks ago, I updated it to 18 because 16 reached its end of life.

Also, I ran some tests with Node 20, and it's still working well (but I don't try to use it deeply)

@advplyr
Copy link
Owner

advplyr commented Jan 20, 2024

There was a bunch more stuff I had to do to bump to node 20. I did that all here 7f35027 so you should be good now if you pull and switch to node 20.
Thanks for the nudge on getting this done!

@advplyr advplyr closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants