Display Error Message in Toasts #1408
Conversation
| @@ -0,0 +1,7 @@ | |||
| export function presentErrorMessage(message: string, error: unknown): string { | |||
There was a problem hiding this comment.
Hey thanks for the PR!
I see your PR exposes the raw error from lemmy. Voyager's current error handling approach is to handle each error and convert to english. This also adds the ability to compose specific, helpful error messages for more casual Voyager/lemmy users. You can see that in helpers/lemmyErrors.ts
I think we could make a function, getCreatePostErrorMessage similar to the existing getVoteErrorMessage.
We could also do that for other errors, as I see in your PR.
There was a problem hiding this comment.
I like the implementation of getVoteErrorMessage but I would make a change where I would still like to add the raw error message in the fallback condition. This way, even if there is an error which we have not handled (mapped to a user-friendly message) there would at least be some information available to the user - which was the original issue I was facing with #1399
There was a problem hiding this comment.
Let me know if the changes in 86fb640 works. Motivation here is to provide some message to the user rather than a generic one, when we have not handled the lemmy version of the error
sharunkumar
force-pushed
the
error-messages
branch
from
a657e7e
to
b3360f9
Compare
Fixes #1399