QR Code Sponsor : command de génération des QR Codes pour les visiteurs #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agallou
reviewed
Apr 27, 2024
| $io = new SymfonyStyle($input, $output); | ||
| $io->title('Génération des QR codes pour les badges des participant.e.s pour les évènements.'); | ||
|
|
||
| if (!$this->lock()) { |
There was a problem hiding this comment.
le lock est géré par quelle classe ?
There was a problem hiding this comment.
Je me suis inspiré d'une autre commande, mais ici pas vraiment besoin du lock, je l'enlève.
agallou
reviewed
Apr 27, 2024
|
|
||
| if (count($tickets) === 0) { | ||
| $io->text('Aucun nouveau code à générer'); | ||
| return 1; |
There was a problem hiding this comment.
pour moi ce n'est pas une erreur, on pourrait renvoyer 0
agallou
reviewed
Apr 27, 2024
|
|
||
| $io->progressFinish(); | ||
| $io->success('Terminé avec succès'); | ||
| return 1; |
There was a problem hiding this comment.
ici il n'y a pas d'erreur, j'aurais plutôt vu un return 0
agallou
reviewed
Apr 27, 2024
| AND afup_inscription_forum.date > :date'; | ||
|
|
||
| return $this->getPreparedQuery($sql) | ||
| ->setParams(['date' => (new \DateTime('2024-01-01 00:00:00'))->getTimestamp()]) //TODO |
There was a problem hiding this comment.
Pour voir ensemble quelle date mettre ici. L'ouverture des inscriptions pour le forum 2024 ?
There was a problem hiding this comment.
est-ce qu'on a besoin d'une date ? je ne pense doit pouvoir s'en passer, ce n'est pas gênant si on génère le QR code sur les anciens événements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ajout d'une commande de génération des QR Codes pour les tickets visiteurs n'ayant pas encore de QR code.
A définir : j'ai pour le moment filtré sur la date à partir du 1er janvier 2024 pour éviter de rétro générer les codes des précédents events. A voir si on laisse comme cela ou si on fait autrement.
La commande