Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Hindi Localization #723

Closed
wants to merge 12 commits into from

Conversation

rajendrakumaryadav
Copy link

@rajendrakumaryadav rajendrakumaryadav commented Jun 24, 2020

Description

Added Hindi Localization..

Related Issues

  • I can run it local but on push git have some issues.
  • At local development machine, I am able to build. But I am not sure that How I can add node_modules/element-ui/lib/locale/lang/hi.js (Please guide me to add the file into source.
    build-completed

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran app with your changes locally?

@agalwood
Copy link
Owner

I think you may need to submit a Hindi i18n PR to Element UI.

Element UI
https://element.eleme.io/#/en-US/component/i18n

If your target language is not included, you are more than welcome to contribute: just add another language config here and create a pull request.

https://github.com/ElemeFE/element/tree/dev/src/locale/lang

@rajendrakumaryadav
Copy link
Author

I think you may need to submit a Hindi i18n PR to Element UI.

Element UI
https://element.eleme.io/#/en-US/component/i18n

If your target language is not included, you are more than welcome to contribute: just add another language config here and create a pull request.

https://github.com/ElemeFE/element/tree/dev/src/locale/lang

Sure...

@agalwood
Copy link
Owner

Like this PR : )
ElemeFE/element#19320

@rajendrakumaryadav
Copy link
Author

Like this PR : )
ElemeFE/element#19320

Pull request added for ElemeFE Locale: Added Hindi #19727

@agalwood
Copy link
Owner

I found that the PR(ElemeFE/element#19727) you submitted to Element UI included package-lock.json. The Element UI team used yarn. I think you should remove the package-lock.json from your PR.

@rajendrakumaryadav
Copy link
Author

I found that the PR(ElemeFE/element#19727) you submitted to Element UI included package-lock.json. The Element UI team used yarn. I think you should remove the package-lock.json from your PR.

package-lock.json removed.

@agalwood
Copy link
Owner

You misunderstood, it is not for you to remove Motrix's package-lock.json! It's Element UI! These are two repo.

ElemeFE/element#19727

@rajendrakumaryadav
Copy link
Author

Ook, No issuess..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants