Explain locking and link to example #795
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koresar
approved these changes
Mar 29, 2019
This was referenced Mar 29, 2019
wingsbob
reviewed
Mar 29, 2019
| @@ -283,6 +283,16 @@ const agenda = new Agenda({maxConcurrency: 20}); | |||
| Takes a `number` which specifies the default number of a specific job that can be running at | |||
| any given moment. By default it is `5`. | |||
|
|
|||
| The concurrency parameter is only important when the job takes longer than its | |||
There was a problem hiding this comment.
Pretty sure this is incorrect. Gonna throw together a minimal repo to try and confirm.
There was a problem hiding this comment.
Ok, I've thrown this together: https://github.com/wingsbob/agenda-concurrency-example
You can run with different default concurrency levels by setting the environment variable CONCURRENCY. The lock time is left as the default (10 mins), so that's definitely not coming into effect.
Agenda#every might not be the best example for concurrency, as it creates single type jobs, which seem to be semi-unique
wingsbob
reviewed
Mar 29, 2019
|
|
||
| * Multiple queues don't process the same job | ||
| * The same job doesn't get run again before it has finished. For example, if a job | ||
| is scheduled to run [`every`](#everyinterval-name-data-options-cb) 5 seconds but |
There was a problem hiding this comment.
maybe use Job#repeatEvery for this example
|
Is this able to be updated or should we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope examples will greatly help newcomers understand how Agenda works!