Add regression test for corrupted packages

__tests__/commands/add.js

@@ -1,7 +1,5 @@
 /* @flow */
 
-import type {Prompt} from 'inquirer';
-
 import {ConsoleReporter} from '../../src/reporters/index.js';
 import * as reporters from '../../src/reporters/index.js';
 import {

__tests__/commands/cache.js

@@ -31,7 +31,14 @@ test('list', async (): Promise<void> => {
   });
 });
 
-test('ls with scoped package', async (): Promise<void> => {
+test('list skips corrupted package', async (): Promise<void> => {
+  await runCache(['list'], {}, 'corrupted', (config, reporter, stdout) => {
+    expect(stdout).not.toContain(JSON.stringify('corrupted'));
+    expect(stdout).toContain(JSON.stringify('good-module'));
+  });
+});
+
+test('ls with scoped packages', async (): Promise<void> => {
   await runInstall({}, 'install-from-authed-private-registry', async (config): Promise<void> => {
     const reporter = new BufferReporter();
     await run(config, reporter, {}, ['list']);

__tests__/fixtures/cache/corrupted/.yarn-cache/v1/corrupted-meta-typo/.yarn-metadata.json

@@ -0,0 +1,6 @@
+{
+  "manifest": {
+    "name": "corrupted",
+    "json-misformatted"
+  }
+}

__tests__/fixtures/cache/corrupted/.yarn-cache/v1/good/.yarn-metadata.json

@@ -0,0 +1,6 @@
+{
+  "manifest": {
+    "name": "good-module",
+    "version": "0.0.0"
+  }
+}

src/cli/commands/cache.js

@@ -41,18 +41,20 @@ async function getPackagesPaths(config, currentPath): Object {
 
 async function getCachedPackages(config): Object {
   const paths = await getPackagesPaths(config, config.cacheFolder);
-  return Promise.all(paths.map(config.readPackageMetadata.bind(config)));
+  return Promise.all(paths.map(path => config.readPackageMetadata(path).catch(error => undefined))).then(packages =>
+    packages.filter(p => !!p),
+  );
 }
 
 async function list(config: Config, reporter: Reporter, flags: Object, args: Array<string>): Promise<void> {
-  const filterOut = ({registry, package: manifest, remote}) => {
+  const filterOut = ({registry, package: manifest, remote} = {}) => {
     if (flags.pattern && !micromatch.contains(manifest.name, flags.pattern)) {
       return false;
     }
     return true;
   };
 
-  const forReport = ({registry, package: manifest, remote}) => [
+  const forReport = ({registry, package: manifest, remote} = {}) => [
     manifest.name,
     manifest.version,
     registry,