Support Electron 4.0.4

- binaries built - update bindings.gyp win_delay_load_hook true - build script targets Node 10.11.0 Electron 4.0.4
agracio · Feb 25, 2019 · 8e6d81d · 8e6d81d
1 parent 4a31922
commit 8e6d81d
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 2 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -157,7 +157,8 @@
     },
     {
       'target_name': 'edge_nativeclr',
-      'win_delay_load_hook': 'false',
+      # Electron 4.x requires this to be true
+      'win_delay_load_hook': 'true',
       'include_dirs': [
         "<!(node -e \"require('nan')\")"
       ],

diff --git a/lib/native/win32/ia32/10.11.0/edge_coreclr.node b/lib/native/win32/ia32/10.11.0/edge_coreclr.node
diff --git a/lib/native/win32/ia32/10.11.0/edge_nativeclr.node b/lib/native/win32/ia32/10.11.0/edge_nativeclr.node
diff --git a/lib/native/win32/x64/10.11.0/edge_coreclr.node b/lib/native/win32/x64/10.11.0/edge_coreclr.node
diff --git a/lib/native/win32/x64/10.11.0/edge_nativeclr.node b/lib/native/win32/x64/10.11.0/edge_nativeclr.node
diff --git a/tools/build.bat b/tools/build.bat
@@ -59,7 +59,7 @@ if "%3" equ "7.9.0" (
 ) else if "%3" equ "10.2.0" (
     SET target=3.0.10
 ) else if "%3" equ "10.11.0" (
-    SET target=v4.0.0-beta.7
+    SET target=v4.0.4
 ) else (
     echo edge-electron-js does not support Node.js %3.
     exit /b -1