Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: format:eslint remove svelte extensions #34

Merged
merged 1 commit into from
Nov 8, 2019
Merged

fix: format:eslint remove svelte extensions #34

merged 1 commit into from
Nov 8, 2019

Conversation

Ancient-Scapes
Copy link
Contributor

Hello, agusID!

I was developing with reference to your repository, but I noticed one problem

It is a bug caused by using eslint-plugin-svelte3 and eslint-plugin-prettier together.

In the current state, if you lint the svelte file, it will break.

For the time being, I tried to remove the svelte file from the format target so as not to brea

sveltejs/svelte#3550

log

boilerplate-svelte on  master is 📦 v1.0.0 via ⬢ v11.2.0 took 5s
➜ yarn format:eslint
yarn run v1.12.3
$ eslint --fix '**/*.{js,ts,svelte}'
ParseError: Expected }
  5 | export let url = ''
  6 |
> 7 | {Router,Link,Route,Home,Explore,url;url=0}
    |                                   ^
Occurred while linting /Users/_user_name_/project/other/boilerplate-svelte/src/App.svelte:3
    at error$1 (/Users/_user_name_/project/other/boilerplate-svelte/node_modules/svelte/compiler.js:13329:20)

@agusID agusID added the bug Something isn't working label Nov 8, 2019
@agusID agusID self-requested a review November 8, 2019 02:18
@agusID agusID merged commit f640466 into agusID:master Nov 8, 2019
@agusID
Copy link
Owner

agusID commented Nov 8, 2019

Fixed. Thank you so much, @Ancient-Scapes .

@agusID agusID removed their request for review November 8, 2019 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants