Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gradle, Kotlin, library version #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update Gradle, Kotlin, library version #37

wants to merge 3 commits into from

Conversation

Amlsakr
Copy link
Collaborator

@Amlsakr Amlsakr commented Jul 30, 2022

No description provided.

@AbdAllahAbdElFattah13
Copy link
Collaborator

AbdAllahAbdElFattah13 commented Aug 5, 2022 •
edited

I have a couple of points:

  • Since we don't have some integration or end-to-end or ui tests, do we run a smoke test even manually for the changes?
  • generally speaking, this kind of upgrade should be carried out gradually بالتدريج as in bigger apps upgrading everything at once can introduce some unintentional issues (either due to compatibility issues or even some breaking changes). I understand that this not a huge app, but I thought to share my thoughts to raise awareness. :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amlsakr @AbdAllahAbdElFattah13