Remove dual-publish plugin

ai · Oct 23, 2023 · 99308fa · 99308fa
1 parent 6a3d9f3
commit 99308fa
Show file tree

Hide file tree

Showing 19 changed files with 14 additions and 267 deletions.
diff --git a/README.md b/README.md
@@ -472,17 +472,13 @@ Plugins:
   about your library is of this size to show the cost of all your
   dependencies.
 * `@size-limit/time` uses headless Chrome to track time to execute JS.
-* `@size-limit/dual-publish` compiles files to ES modules with [`dual-publish`]
-  to check size after tree-shaking.
 
 Plugin presets:
 
 * `@size-limit/preset-app` contains `file` and `time` plugins.
 * `@size-limit/preset-big-lib` contains `webpack`, `file`, and `time` plugins.
 * `@size-limit/preset-small-lib` contains `esbuild` and `file` plugins.
 
-[`dual-publish`]: https://github.com/ai/dual-publish
-
 
 #### Third-Party Plugins
 

diff --git a/fixtures/combine/index.js b/fixtures/combine/index.js
@@ -2,4 +2,4 @@ const a = 1
 
 const b = 'hfdjhwqndshdsonbavashskd;a[spdkdjsba;sx[cabsdfddf'
 
-module.exports = { a, b }
+export { a, b }
diff --git a/fixtures/combine/package.json b/fixtures/combine/package.json
@@ -2,9 +2,7 @@
   "name": "combine",
   "private": true,
   "devDependencies": {
-    "@size-limit/dual-publish": ">= 0.0.0",
     "@size-limit/preset-small-lib": ">= 0.0.0",
-    "dual-publish": ">= 0.0.0",
     "size-limit": ">= 0.0.0",
     "redux": ">= 0.0.0"
   },

diff --git a/fixtures/integration-esm/index.js b/fixtures/integration-esm/index.js
@@ -1,3 +1,3 @@
-let { VERY_LONG_NAME_FOR_CONST_TO_TEST_TREE_SHAKING, method } = require('./lib')
+import { VERY_LONG_NAME_FOR_CONST_TO_TEST_TREE_SHAKING, method } from './lib'
 
-module.exports = { VERY_LONG_NAME_FOR_CONST_TO_TEST_TREE_SHAKING, method }
+export { VERY_LONG_NAME_FOR_CONST_TO_TEST_TREE_SHAKING, method }
diff --git a/fixtures/integration-esm/lib/index.js b/fixtures/integration-esm/lib/index.js
@@ -1,7 +1,5 @@
-const VERY_LONG_NAME_FOR_CONST_TO_TEST_TREE_SHAKING = 1
+export const VERY_LONG_NAME_FOR_CONST_TO_TEST_TREE_SHAKING = 1
 
-function method() {
+export function method() {
   console.log('1111111111111111')
 }
-
-module.exports = { VERY_LONG_NAME_FOR_CONST_TO_TEST_TREE_SHAKING, method }
diff --git a/fixtures/integration-esm/package.json b/fixtures/integration-esm/package.json
@@ -3,8 +3,6 @@
   "private": true,
   "devDependencies": {
     "@size-limit/preset-small-lib": ">= 0.0.0",
-    "@size-limit/dual-publish": ">= 0.0.0",
-    "dual-publish": ">= 0.0.0",
     "size-limit": ">= 0.0.0"
   },
   "size-limit": [

diff --git a/package.json b/package.json
@@ -9,7 +9,6 @@
   },
   "devDependencies": {
     "@logux/eslint-config": "^52.0.1",
-    "@size-limit/dual-publish": "workspace:^",
     "@size-limit/esbuild": "workspace:^",
     "@size-limit/esbuild-why": "workspace:^",
     "@size-limit/file": "workspace:^",
@@ -22,7 +21,6 @@
     "@vitest/coverage-v8": "^0.34.6",
     "clean-publish": "^4.2.0",
     "cross-spawn": "^7.0.3",
-    "dual-publish": "^3.0.1",
     "eslint": "^8.52.0",
     "eslint-config-standard": "^17.1.0",
     "eslint-plugin-import": "^2.29.0",

diff --git a/packages/dual-publish/.npmignore b/packages/dual-publish/.npmignore
diff --git a/packages/dual-publish/LICENSE b/packages/dual-publish/LICENSE
diff --git a/packages/dual-publish/README.md b/packages/dual-publish/README.md
diff --git a/packages/dual-publish/index.js b/packages/dual-publish/index.js
diff --git a/packages/dual-publish/package.json b/packages/dual-publish/package.json
diff --git a/packages/dual-publish/test/fixtures/index.js b/packages/dual-publish/test/fixtures/index.js
diff --git a/packages/dual-publish/test/fixtures/package.json b/packages/dual-publish/test/fixtures/package.json
diff --git a/packages/dual-publish/test/index.test.js b/packages/dual-publish/test/index.test.js
diff --git a/packages/size-limit/calc.js b/packages/size-limit/calc.js
@@ -7,17 +7,13 @@ export default async function calc(plugins, config, createSpinner) {
       if (plugin['wait' + number] && createSpinner) {
         spinner = createSpinner(plugin['wait' + number]).start()
       }
-      if (plugin['step' + number] || plugin['all' + number]) {
+      if (plugin['step' + number]) {
         try {
-          if (plugin['all' + number]) {
-            await plugin['all' + number](config)
-          } else {
-            await Promise.all(
-              config.checks.map(i => {
-                return plugin['step' + number](config, i)
-              })
-            )
-          }
+          await Promise.all(
+            config.checks.map(i => {
+              return plugin['step' + number](config, i)
+            })
+          )
         } catch (e) {
           if (spinner) spinner.error()
           throw e

diff --git a/packages/size-limit/test/__snapshots__/size-limit-error.test.js.snap b/packages/size-limit/test/__snapshots__/size-limit-error.test.js.snap
@@ -2,7 +2,7 @@
 
 exports[`has error for CLI error 1`] = `
 "[41m[30m ERROR [39m[49m [31mcli-tool error: Module not found
-  @ multi ./dual-publish-tmp/index.js index[0][39m
+  @ multi ./tmp/index.js index[0][39m
 "
 `;
 

diff --git a/packages/size-limit/test/size-limit-error.test.js b/packages/size-limit/test/size-limit-error.test.js
@@ -41,7 +41,7 @@ it('has error for CLI error', () => {
   let err = new SizeLimitError(
     'cmdError',
     'cli-tool',
-    'Module not found\n  @ multi ./dual-publish-tmp/index.js index[0]'
+    'Module not found\n  @ multi ./tmp/index.js index[0]'
   )
   expect(print(err)).toMatchSnapshot()
 })