Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: loose strictness of peer dependency requirement of tslib #327

Conversation

mcmxcdev
Copy link
Contributor

@mcmxcdev mcmxcdev commented Jun 9, 2023

Still no clue where the peer dependency requirement comes from, I don't see it defined in either size-limit-node-esbuild or size-limit itself.

Now users could update to tslib 2.5.3 at least to satisfy and match the dependency requirement.

Closes #326


  • re-install size-limit-node-esbuild to refresh tslib from 2.5.0 to 2.5.3

- re-install size-limit-node-esbuild to refresh tslib from 2.5.0 to 2.5.3
@mcmxcdev mcmxcdev marked this pull request as ready for review June 9, 2023 19:32
@ai
Copy link
Owner

ai commented Jun 9, 2023

It comes from package.json (in project’s root) and fixtures/plugins/package.json

@ai ai merged commit 5618368 into ai:main Jun 9, 2023
4 checks passed
@mcmxcdev
Copy link
Contributor Author

mcmxcdev commented Jun 9, 2023

It comes from package.json (in project’s root) and fixtures/plugins/package.json

That's where size-limit-node-esbuild is installed yes, but not where peerDependencies: { "tslib": "2.5.0" } is coming from.

I think I figured out what the actual issue is, read more: #327 (comment)

@ai
Copy link
Owner

ai commented Jun 9, 2023

Have no idea. The lock file which you fixed is not in any npm package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen strictness of peer dependency requirement of tslib
2 participants