Support css content in esbuild plugin #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lgtm. Do you want to add anything (PR is marked as draft) or we ready for merge? |
just-boris
commented
Mar 21, 2024
| } else { | ||
| throw new SizeLimitError('unknownEntry', i) | ||
| for (let entry of check.entry) { | ||
| let matches = Object.keys(outputs).filter(key => parse(key).name === entry) |
There was a problem hiding this comment.
Make sure entry matching still uses path.parse(entry).name as before
just-boris
commented
Mar 21, 2024
| @@ -37,7 +37,7 @@ const MESSAGES = { | |||
| unknownArg: arg => | |||
| `Unknown argument *${arg}*. Check command for typo and read docs.`, | |||
| unknownEntry: entry => | |||
| `Size Limit didn’t find *${entry}* entry in custom Webpack config`, | |||
| `Size Limit didn’t find *${entry}* entry in the custom bundler config`, | |||
There was a problem hiding this comment.
Spent some time in confusion how esbuild change may break anything with webpack config. Let's rename the error message to a more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse('index.css').nameandparse('index.js').nameprodiuces the sameindexkey, which overwrites one of the entries.Use
baseto prevent conflicts and useindex.js/index.cssas the keys.Fixes #360