Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access Token Refresh Endpoint #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krzepah
Copy link
Contributor

@krzepah krzepah commented Jul 13, 2019

Changes:

  • login & register sends the refreshToken as well
  • added crypto dependency

login & register send the refreshToken as well
added crypto dependency
@krzepah krzepah changed the title Refresh Endpoint Access Token Refresh Endpoint Jul 13, 2019
@aichbauer
Copy link
Owner

@krzepah we would also need the check in the authService, right now we only use the refreshtoken for the login...

see #28 (comment)

@aichbauer
Copy link
Owner

@krzepah Could you please add information in the readme on how to use it

@krzepah
Copy link
Contributor Author

krzepah commented Aug 7, 2019

Hello there,

Sorry for the delay, I've started working with something else than express (polka) ; and it delayed this issue in my priorities.

I'd be happy if you could take over, unfortunately i'm not planning to use express / this repo anymore,

o7

Copy link
Contributor

@ace3 ace3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the refresh token can be used.

you must do it yourself how to handle the refresh token.
since refresh token is stored in the user, so it's easier to invalidate the refresh token when you logout or forget password.

@@ -39,6 +39,7 @@
"bcrypt-nodejs": "^0.0.3",
"body-parser": "^1.18.2",
"cors": "^2.8.4",
"crypto": "^1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's now build in on nodejs, but the people using this is still a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants