Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8089/dc38630b backport][3.10] 💅 Propagate error causes via asyncio protocols #8161

Conversation

webknjaz
Copy link
Member

This is a backport of PR #8089 as merged into master (dc38630).

This is supposed to unify setting exceptions on the future objects, allowing to also attach their causes whenever available. It'll make possible for the end-users to see more detailed tracebacks.

It's also supposed to help with tracking down what's happening with #4581.

PR #8089

Co-Authored-By: J. Nick Koston nick@koston.org
Co-Authored-By: Sam Bull aa6bs0@sambull.org
(cherry picked from commit dc38630)

@webknjaz webknjaz self-assigned this Feb 16, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Feb 16, 2024
@webknjaz webknjaz force-pushed the patchback/backports/3.10/dc38630b168a169139974617d75e176530c91696/pr-8089 branch from 8c34ce1 to 8a773e7 Compare February 16, 2024 04:13
…ia asyncio protocols

This is supposed to unify setting exceptions on the future objects,
allowing to also attach their causes whenever available. It'll make
possible for the end-users to see more detailed tracebacks.

It's also supposed to help with tracking down what's happening
with aio-libs#4581.

PR aio-libs#8089

Co-Authored-By: J. Nick Koston <nick@koston.org>
Co-Authored-By: Sam Bull <aa6bs0@sambull.org>
(cherry picked from commit dc38630)
@webknjaz webknjaz force-pushed the patchback/backports/3.10/dc38630b168a169139974617d75e176530c91696/pr-8089 branch from 8a773e7 to ada970a Compare February 16, 2024 04:17
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6cb21d1) 97.46% compared to head (ada970a) 97.46%.

Files Patch % Lines
aiohttp/client_reqrep.py 88.88% 0 Missing and 1 partial ⚠️
aiohttp/web_ws.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8161   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files         108      108           
  Lines       33010    33027   +17     
  Branches     3953     3955    +2     
=======================================
+ Hits        32172    32190   +18     
+ Misses        635      634    -1     
  Partials      203      203           
Flag Coverage Δ
CI-GHA 97.37% <97.26%> (+<0.01%) ⬆️
OS-Linux 97.05% <94.52%> (-0.01%) ⬇️
OS-Windows 94.60% <97.18%> (+<0.01%) ⬆️
OS-macOS 96.87% <94.52%> (-0.01%) ⬇️
Py-3.10.11 94.50% <97.18%> (+<0.01%) ⬆️
Py-3.10.13 96.83% <94.52%> (-0.01%) ⬇️
Py-3.11.7 96.38% <94.52%> (-0.01%) ⬇️
Py-3.11.8 96.50% <94.52%> (-0.01%) ⬇️
Py-3.12.1 96.49% <94.52%> (-0.01%) ⬇️
Py-3.12.2 ?
Py-3.8.10 94.49% <97.18%> (+<0.01%) ⬆️
Py-3.8.18 96.77% <94.52%> (-0.01%) ⬇️
Py-3.9.13 94.49% <97.18%> (-0.01%) ⬇️
Py-3.9.18 96.82% <94.52%> (+<0.01%) ⬆️
Py-pypy7.3.15 96.35% <94.52%> (-0.01%) ⬇️
VM-macos 96.87% <94.52%> (-0.01%) ⬇️
VM-ubuntu 97.05% <94.52%> (-0.01%) ⬇️
VM-windows 94.60% <97.18%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz webknjaz enabled auto-merge (squash) February 16, 2024 04:38
@webknjaz webknjaz merged commit d4322e7 into aio-libs:3.10 Feb 16, 2024
24 of 28 checks passed
@webknjaz webknjaz deleted the patchback/backports/3.10/dc38630b168a169139974617d75e176530c91696/pr-8089 branch April 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant