[PR #8089/dc38630b backport][3.9] 💅 Propagate error causes via asyncio protocols #8162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
…a asyncio protocols This is supposed to unify setting exceptions on the future objects, allowing to also attach their causes whenever available. It'll make possible for the end-users to see more detailed tracebacks. It's also supposed to help with tracking down what's happening with aio-libs#4581. PR aio-libs#8089 Co-Authored-By: J. Nick Koston <nick@koston.org> Co-Authored-By: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit dc38630)
webknjaz
force-pushed
the
patchback/backports/3.9/dc38630b168a169139974617d75e176530c91696/pr-8089
branch
from
7af2680
to
b3a5b6c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 3.9 #8162 +/- ##
==========================================
+ Coverage 97.29% 97.37% +0.07%
==========================================
Files 108 108
Lines 32611 32628 +17
Branches 3873 3875 +2
==========================================
+ Hits 31730 31770 +40
+ Misses 673 654 -19
+ Partials 208 204 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
webknjaz
deleted the
patchback/backports/3.9/dc38630b168a169139974617d75e176530c91696/pr-8089
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8089 as merged into master (dc38630).
This is supposed to unify setting exceptions on the future objects, allowing to also attach their causes whenever available. It'll make possible for the end-users to see more detailed tracebacks.
It's also supposed to help with tracking down what's happening with #4581.
PR #8089
Co-Authored-By: J. Nick Koston nick@koston.org
Co-Authored-By: Sam Bull aa6bs0@sambull.org
(cherry picked from commit dc38630)