Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #265 - _process_auth implementation #266

Closed
wants to merge 5 commits into from

Conversation

AlexLisovoy
Copy link
Contributor

@AlexLisovoy AlexLisovoy commented Mar 7, 2018

No description provided.

@codecov
Copy link

codecov bot commented Mar 7, 2018

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #266   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files           9        9           
  Lines        1157     1157           
  Branches      172      172           
=======================================
  Hits         1075     1075           
  Misses         53       53           
  Partials       29       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4a676...81693f2. Read the comment docs.

@jettify
Copy link
Member

jettify commented Mar 10, 2018

Looks good, but we need test case...

@jettify
Copy link
Member

jettify commented Mar 10, 2018

Do you know how to setup mysql server to support that auth? We can build docker image and test agains it.

@AlexLisovoy
Copy link
Contributor Author

I'm working on test cases. During next week I will update this pr. My mysql version is 5.7.20, but I think it can be easeally reproduced on lower mysql version, because MySQL announce the AuthSwitch packet which contains two component auth_plugin_name and auth_data in version 5.5.

@AlexLisovoy
Copy link
Contributor Author

@jettify I added test that can easily reproduce the issue locally with docker

@jettify
Copy link
Member

jettify commented Apr 19, 2018

Implementation merged to master with this PR #280

@jettify
Copy link
Member

jettify commented Apr 19, 2018

Thanks a lot!

@jettify jettify closed this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants