-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepared statement #508
base: master
Are you sure you want to change the base?
Prepared statement #508
Conversation
This pull request fixes 1 alert when merging e1e6621 into d842ec3 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging f6ca5f9 into d842ec3 - view on LGTM.com fixed alerts:
|
f6ca5f9
to
20a439f
Compare
Codecov Report
@@ Coverage Diff @@
## master #508 +/- ##
==========================================
- Coverage 87.54% 82.48% -5.06%
==========================================
Files 9 13 +4
Lines 1228 2312 +1084
Branches 177 357 +180
==========================================
+ Hits 1075 1907 +832
- Misses 124 316 +192
- Partials 29 89 +60
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging 20a439f into d842ec3 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging c9f603a into d842ec3 - view on LGTM.com fixed alerts:
|
Tests failed because of JSON is not supported in MariaDB 5.5 |
This pull request fixes 1 alert when merging e352475 into d842ec3 - view on LGTM.com fixed alerts:
|
Thank you for the PR, unfortunately due to aiomysql being based on PyMySQL this should first be implemented in PyMySQL and then ported to aiomysql. see PyMySQL/PyMySQL#202 for the related issue in PyMySQL. |
What do these changes do?
Implement MySQL Prepared Statements
Are there changes in behavior for the user?
No change to existing features.
Related issue number
Checklist
CHANGES
folder<issue_id>.<type>
(e.g.588.bugfix
)issue_id
change it to the pr id after creating the PR.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.