Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused test code #710

Merged
merged 1 commit into from
Jan 30, 2022
Merged

remove unused test code #710

merged 1 commit into from
Jan 30, 2022

Conversation

Nothing4You
Copy link
Collaborator

@Nothing4You Nothing4You commented Jan 30, 2022

What do these changes do?

remove unused session_id test fixture
this was introduced in #275 for running the database in a container but is no longer needed.

Are there changes in behavior for the user?

no

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #710 (b2067a7) into master (32cbeac) will decrease coverage by 0.55%.
The diff coverage is n/a.

❗ Current head b2067a7 differs from pull request most recent head e3bce0e. Consider uploading reports for the commit e3bce0e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #710      +/-   ##
==========================================
- Coverage   92.68%   92.13%   -0.56%     
==========================================
  Files          35       35              
  Lines        5415     5404      -11     
  Branches      581      579       -2     
==========================================
- Hits         5019     4979      -40     
- Misses        309      332      +23     
- Partials       87       93       +6     
Flag Coverage Δ
ubuntu-latest_3.10_mariadb-10.2 ?
ubuntu-latest_3.10_mariadb-10.3 ?
ubuntu-latest_3.10_mariadb-10.4 ?
ubuntu-latest_3.10_mariadb-10.5 ?
ubuntu-latest_3.10_mariadb-10.6 ?
ubuntu-latest_3.10_mariadb-10.7 ?
ubuntu-latest_3.10_mysql-5.7 90.26% <ø> (+0.03%) ⬆️
ubuntu-latest_3.10_mysql-8.0 91.67% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mariadb-10.2 ?
ubuntu-latest_3.7_mariadb-10.3 ?
ubuntu-latest_3.7_mariadb-10.4 ?
ubuntu-latest_3.7_mariadb-10.5 ?
ubuntu-latest_3.7_mariadb-10.6 ?
ubuntu-latest_3.7_mariadb-10.7 ?
ubuntu-latest_3.7_mysql-5.7 89.72% <ø> (+0.03%) ⬆️
ubuntu-latest_3.7_mysql-8.0 91.21% <ø> (+0.04%) ⬆️
ubuntu-latest_3.8_mariadb-10.2 ?
ubuntu-latest_3.8_mariadb-10.3 ?
ubuntu-latest_3.8_mariadb-10.4 ?
ubuntu-latest_3.8_mariadb-10.5 ?
ubuntu-latest_3.8_mariadb-10.6 ?
ubuntu-latest_3.8_mariadb-10.7 ?
ubuntu-latest_3.8_mysql-5.7 90.30% <ø> (+0.03%) ⬆️
ubuntu-latest_3.8_mysql-8.0 91.69% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mariadb-10.2 ?
ubuntu-latest_3.9_mariadb-10.3 ?
ubuntu-latest_3.9_mariadb-10.4 ?
ubuntu-latest_3.9_mariadb-10.5 ?
ubuntu-latest_3.9_mariadb-10.6 ?
ubuntu-latest_3.9_mariadb-10.7 ?
ubuntu-latest_3.9_mysql-5.7 90.17% <ø> (+0.03%) ⬆️
ubuntu-latest_3.9_mysql-8.0 91.56% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/conftest.py 88.00% <ø> (+0.25%) ⬆️
tests/test_basic.py 97.88% <ø> (-0.10%) ⬇️
tests/test_deserialize_cursor.py 69.69% <0.00%> (-30.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32cbeac...e3bce0e. Read the comment docs.

this was introduced in #275 for running the database in a container but is no longer needed
@Nothing4You Nothing4You changed the title remove unused session_id test fixture remove unused test code Jan 30, 2022
@Nothing4You Nothing4You force-pushed the remove-unused-test-code branch 2 times, most recently from b2067a7 to e3bce0e Compare January 30, 2022 03:59
@Nothing4You Nothing4You merged commit 7939aeb into master Jan 30, 2022
@Nothing4You Nothing4You deleted the remove-unused-test-code branch January 30, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant