Update build-system requirements of setuptools-scm to >= 7.0.5 #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml: Increase the build-system requirements of setuptools-scm to >= 7.0.5, which obsoletes setuptools-scm-git-archive. Issues around the use of setuptools-scm as discussed in aio-libs#809 and pypa/setuptools_scm#745 have been fixed in pypa/setuptools_scm@b7c0d0d and relesed with https://github.com/pypa/setuptools_scm/releases/tag/v7.0.5
CHANGES.txt: Add changelog entry about udpates to build-system requirements.
Codecov Report
@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 93.64% 93.64%
=======================================
Files 36 36
Lines 5538 5538
Branches 895 895
=======================================
Hits 5186 5186
Misses 262 262
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Nothing4You since you seem to be the most active recently, could you have a look and merge this please? :) |
|
thanks for the PR, I'll get to it soonish |
@Nothing4You anything more I can do? Is the change okay this way? |
webknjaz
requested changes
May 27, 2023
This was referenced Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyproject.toml:
Increase the build-system requirements of setuptools-scm to >= 7.0.5, which obsoletes setuptools-scm-git-archive.
Issues around the use of setuptools-scm as discussed in #809 and pypa/setuptools_scm#745
have been fixed in
pypa/setuptools_scm@b7c0d0d and relesed with
https://github.com/pypa/setuptools_scm/releases/tag/v7.0.5
What do these changes do?
Increase the build-system requirements of setuptools-scm to >= 7.0.5, which obsoletes setuptools-scm-git-archive.
Are there changes in behavior for the user?
setuptools-scm-git-archive is no longer required during build time.
Related issue number
#809
pypa/setuptools_scm#745
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.