Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old patches: preventing unexpected exceptions and freezes #982

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Old patches: preventing unexpected exceptions and freezes #982

wants to merge 6 commits into from

Conversation

andr-04
Copy link

@andr-04 andr-04 commented Apr 18, 2024 •
edited

What do these changes do?

These are old patches aimed to fix the following:

  1. Safe writing to socket and return OperationalError in case the connection was lost: Catching connection lost on _write_bytes #453.
  2. Notify connection pool in any case, even if an exception happened during the connection, to resume the connection by another task in a queue (otherwise they are being frozen).

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

andr-04 and others added 6 commits December 2, 2019 16:10
@andr-04
Catching connection lost on _write_bytes
31ecda6
@andr-04
Merge commit '0a8af2355562ea961477738d66b3334332447186'
d6d9b51 
* commit '0a8af2355562ea961477738d66b3334332447186':
  Bump version and tweak setup.py (aio-libs#540)
  Fill changelog for 0.0.21 release (aio-libs#538)
  Support python 3.7 and 3.8 in tests and travis CI
  Update dependencies (aio-libs#485)
  chore(flake8): fixed flake8 errors (aio-libs#484)
  added support for sqlalchemy default parameters aio-libs#455 (aio-libs#456)
  Fix flake
  Fixed invalid datatime for MySQL 5.7
  Rewrote tests to use pytest exclusively
  Fixed linting
  Attempted to move db completely to docker
  Fix Travis attempt 1
  Fix aio-libs#454
@andr-04
_cond.notify() on exceptions as well to prevent infinity waiting on w…
21871e6 
…ait_closed
@andr-04
Merge v0.1.1 (commit '8a32f052a16dc3886af54b98f4d91d95862bfb8e')
b67267d 
* commit '8a32f052a16dc3886af54b98f4d91d95862bfb8e': (92 commits)
  Update changelog for 0.1.1 release (aio-libs#784)
  Bump pytest from 7.1.1 to 7.1.2 (aio-libs#781)
  XFail test_issue_36 for now to avoid failing for unrelated changes (aio-libs#779)
  Skip codecov uploads in scheduled daily tests (aio-libs#778)
  Bump codecov/codecov-action from 3.0.0 to 3.1.0 (aio-libs#777)
  Fix SSL connection handshake charset not respecting client configuration (aio-libs#776)
  Bump ncipollo/release-action from 1.9.0 to 1.10.0 (aio-libs#766)
  Bump actions/cache from 3.0.1 to 3.0.2 (aio-libs#771)
  Bump actions/download-artifact from 2 to 3 (aio-libs#765)
  Bump actions/upload-artifact from 2 to 3 (aio-libs#767)
  Update changelog for release (aio-libs#769)
  Checkout git source to access changelog for GitHub release creation
  Change next version to 0.1.0 in changelog
  Fix GHA badge in readme after aio-libs#734 (aio-libs#762)
  Fix SSCursor raising query timeout error on wrong query on MySQL DB (aio-libs#761)
  Specify explicit language for literal blocks in CONTRIBUTING.rst to reduce warnings in doc builds (aio-libs#760)
  fix `make checkrst` (aio-libs#759)
  Update sphinx requirement from <4.4.1,>=1.8.1 to 4.5.0 (aio-libs#751)
  Bump codecov/codecov-action from 2.1.0 to 3.0.0 (aio-libs#758)
  Bump actions/cache from 2.1.7 to 3.0.1 (aio-libs#752)
  ...
@andr-04
Merge branch 'master' of https://github.com/aio-libs/aiomysql into ol…
db9c83e 
…d-patches

* 'master' of https://github.com/aio-libs/aiomysql: (78 commits)
  Update changelog for 0.2.0 release
  Migrate GHA pypi publish action inputs to kebab-case
  Bump pytest from 7.3.1 to 7.3.2
  Bump coverage from 7.2.6 to 7.2.7
  Migrate away from using deprecated `set-output` in GHA
  Implement Trusted Publishing for PyPI
  Remove tests for EoL MariaDB versions 10.3, 10.7 and 10.8, added tests for MariaDB 10.9, 10.10, 10.11
  Add pre-commit config for pyupgrade --py37-plus
  Modernize code with `pyupgrade --py37-plus`
  Implement Trusted Publishing for Test PyPI
  Bump codecov/codecov-action from 3.1.3 to 3.1.4
  Bump coverage from 7.2.5 to 7.2.6
  Bump pytest-cov from 4.0.0 to 4.1.0
  Bump pypa/gh-action-pypi-publish from 1.5.1 to 1.8.6
  Bump coverage from 6.5.0 to 7.2.5
  Bring flake8 version in GitHub actions in sync with requirements-dev.txt
  Add CodeQL workflow for GitHub code scanning
  Bump py-actions/flake8 from 2.2.0 to 2.2.1
  Bump codecov/codecov-action from 3.1.1 to 3.1.3
  Bump ipdb from 0.13.9 to 0.13.13
  ...

# Conflicts:
#	aiomysql/connection.py
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
6b8fc6b 
for more information, see https://pre-commit.ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andr-04