add development.in #200
add development.in #200
Conversation
|
Hi. Thx for ur contribution. I think that we don't need pip-tools for develop our template. But it'll so good for users who use create-aio-app. So instead move requirements-dev.txt what do u think about to do the same with this files https://github.com/aio-libs/create-aio-app/tree/master/create_aio_app/template/%7B%7Bcookiecutter.project_name%7D%7D/requirements? What do u think about it? 😀 |
|
What do you think? |
|
Sorry, but i don't understand what u wanna do. In issues which u attached to current pull request described about dependence which exist in this directory |
|
hello, sorry I didn't get it in the first place. What do you think of these changes now? |
| psycopg2-binary==2.8.4 | ||
| alembic==1.4.1 | ||
| aioredis==1.3.1 | ||
| uvloop==0.14.0 |
There was a problem hiding this comment.
In production.txt u can see that we don't add all requirements.
{%- if cookiecutter.use_postgres == 'y' %}
aiopg[sa]==1.0.0
...
{%- endif %}
it's important and we need to move this logic to .in files too.
| @@ -0,0 +1,39 @@ | |||
| # | |||
There was a problem hiding this comment.
it looks like input from pip-compile, are u sure that it's correct for .in file?
Sphinx==2.4.4
sphinx-autodoc-typehints==1.10.3
sphinxcontrib-websupport==1.2.0
doc8==0.8.0
|
|
||
| echo(click.style("\n\nSuccessfully generated!\n", fg="bright_green",)) | ||
| echo("cd " + click.style(f"{folder}/", fg="bright_blue")) | ||
| show_commands(folder) |
There was a problem hiding this comment.
how does this part (main.py, constants.py, __init__.py) connected with pip-tools?
|
|
What do these changes do?
I add
development.intorequirementsfolder.Are there changes in behavior for the user?
no they aren't. Just to differentiate between direct dependencies and others.
Related issue number
issue #181
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.