Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pydantic version #1322

Merged
merged 2 commits into from Sep 25, 2023
Merged

Fix pydantic version #1322

merged 2 commits into from Sep 25, 2023

Conversation

Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Sep 25, 2023

Description

Pydantic 2.4 crashes with breaking changes!

@samuelcolvin, you promised not to break minor versions...

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Olegt0rr Olegt0rr added the bug Something is wrong with the framework label Sep 25, 2023
@Olegt0rr Olegt0rr self-assigned this Sep 25, 2023
@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Sep 25, 2023
@github-actions
Copy link

github-actions bot commented Sep 25, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

@Olegt0rr Olegt0rr marked this pull request as ready for review September 25, 2023 15:22
@Olegt0rr Olegt0rr requested a review from a team September 25, 2023 15:22
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #1322 (59cc452) into dev-3.x (fec1389) will not change coverage.
Report is 1 commits behind head on dev-3.x.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1322   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          369       369           
  Lines         9428      9428           
=========================================
  Hits          9428      9428           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@JrooTJunior JrooTJunior merged commit 1dcb830 into dev-3.x Sep 25, 2023
22 checks passed
@Olegt0rr Olegt0rr deleted the fix-pydantic branch September 25, 2023 16:39
@JrooTJunior
Copy link
Member

Breking change: pydantic/pydantic#7523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants