Update kotlin to 1.8.10, xprocessing to 1.6.0-alpha01 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elihart
commented
Apr 5, 2023
| @@ -107,7 +106,11 @@ abstract class BaseProcessor( | |||
| } catch (e: Throwable) { | |||
| // Errors thrown from within KSP can get lost, making the root cause of an issue hidden. | |||
| // This helps to surface all thrown errors. | |||
| messager.printMessage(Diagnostic.Kind.ERROR, e.stackTraceToString()) | |||
| if (e is ShowkaseProcessorException && e.element != null) { | |||
There was a problem hiding this comment.
i noticed that the showkase logger in place doesn't every actually get used, so error messages haven't been logging the element. i added this to help, but it seems like there needs to be a bigger clean up
| ) | ||
| } | ||
|
|
||
| when (environment.backend) { |
There was a problem hiding this comment.
in KSP the type is now the color value class, not just Long
| .kind | ||
|
|
||
| enclosingElementKind == FILE_FACADE_KIND | ||
| return kotlinMetadata == null |
There was a problem hiding this comment.
there is a new version of the metadata class that had breaking changes
pmecho
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates kotlin, ksp, and the xprocessing library.
Notably, the androidx.room:room-compiler-processing library (aka xprocessing) has been updated to 2.6.0-alpha01. This version is incompatible with previous versions due to a breaking API change. All annotation processors using this library must be on the same version. Other annotation processors such as Epoxy and Paris also use xprocessing and if you use them you need to use a version of them that also uses xprocessing 2.6.0-alpha01
For that reason we shouldn't merge this until all other planned work is merged and released so that it can be used without forcing updates of other libraries