airbnb · andersu · Apr 20, 2023 · Apr 28, 2023 · May 9, 2023 · May 9, 2023
diff --git a/...azzi_screenshot_test_for_all_UI_elements/output/MyScreenshotTest_PaparazziShowkaseTest.kt b/...azzi_screenshot_test_for_all_UI_elements/output/MyScreenshotTest_PaparazziShowkaseTest.kt
@@ -35,7 +35,9 @@ public class MyScreenshotTest_PaparazziShowkaseTest : MyScreenshotTest() {
         uiMode: PaparazziShowkaseUIMode,
   ): Unit {
     paparazzi.unsafeUpdateConfig(config.deviceConfig.copy(softButtons = false))
-    takePaparazziSnapshot(paparazzi, elementPreview, direction, uiMode)
+    if (shouldTakeScreenshot(config.deviceConfig, elementPreview.group)) {
+      takePaparazziSnapshot(paparazzi, elementPreview, direction, uiMode)
+    }
   }
 
   private object PaparazziShowkasePreviewProvider : TestParameter.TestParameterValuesProvider {

diff --git a/...paparazzi_screenshot_test_for_composable/output/MyScreenshotTest_PaparazziShowkaseTest.kt b/...paparazzi_screenshot_test_for_composable/output/MyScreenshotTest_PaparazziShowkaseTest.kt
@@ -35,7 +35,9 @@ public class MyScreenshotTest_PaparazziShowkaseTest : MyScreenshotTest() {
         uiMode: PaparazziShowkaseUIMode,
   ): Unit {
     paparazzi.unsafeUpdateConfig(config.deviceConfig.copy(softButtons = false))
-    takePaparazziSnapshot(paparazzi, elementPreview, direction, uiMode)
+    if (shouldTakeScreenshot(config.deviceConfig, elementPreview.group)) {
+      takePaparazziSnapshot(paparazzi, elementPreview, direction, uiMode)
+    }
   }
 
   private object PaparazziShowkasePreviewProvider : TestParameter.TestParameterValuesProvider {

diff --git a/..._screenshot_test_for_composable/output/MyPaparazziScreenshotTest_PaparazziShowkaseTest.kt b/..._screenshot_test_for_composable/output/MyPaparazziScreenshotTest_PaparazziShowkaseTest.kt
@@ -35,7 +35,9 @@ public class MyPaparazziScreenshotTest_PaparazziShowkaseTest : MyPaparazziScreen
         uiMode: PaparazziShowkaseUIMode,
   ): Unit {
     paparazzi.unsafeUpdateConfig(config.deviceConfig.copy(softButtons = false))
-    takePaparazziSnapshot(paparazzi, elementPreview, direction, uiMode)
+    if (shouldTakeScreenshot(config.deviceConfig, elementPreview.group)) {
+      takePaparazziSnapshot(paparazzi, elementPreview, direction, uiMode)
+    }
   }
 
   private object PaparazziShowkasePreviewProvider : TestParameter.TestParameterValuesProvider {

diff --git a/...ava/com/airbnb/android/showkase/processor/writer/PaparazziShowkaseScreenshotTestWriter.kt b/...ava/com/airbnb/android/showkase/processor/writer/PaparazziShowkaseScreenshotTestWriter.kt
@@ -198,19 +198,24 @@ class PaparazziShowkaseScreenshotTestWriter(private val environment: XProcessing
                         )
                         .build()
                 )
-                .addCode(
+                .addStatement(
                     "%N.unsafeUpdateConfig(%N.deviceConfig.copy(softButtons = false))",
                     "paparazzi",
                     "config"
                 )
-                .addCode("\n")
-                .addCode(
+                .beginControlFlow(
+                    "if (shouldTakeScreenshot(%N.deviceConfig, %N.group))",
+                    "config",
+                    "elementPreview"
+                )
+                .addStatement(
                     "takePaparazziSnapshot(%N, %N, %N, %N)",
                     "paparazzi",
                     "elementPreview",
                     "direction",
                     "uiMode"
                 )
+                .endControlFlow()
                 .build()
         )
     }

diff --git a/...main/java/com/airbnb/android/showkase/screenshot/testing/paparazzi/sample/CustomButton.kt b/...main/java/com/airbnb/android/showkase/screenshot/testing/paparazzi/sample/CustomButton.kt
@@ -9,6 +9,7 @@ import androidx.compose.material.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.TextStyle
 import androidx.compose.ui.unit.dp
 import com.airbnb.android.showkase.annotation.ShowkaseComposable
@@ -69,6 +70,16 @@ fun PreviewCustomButtonSmall() {
     )
 }
 
+@ShowkaseComposable(name = "CustomButton", group = "Localised", styleName = "Small")
+@Composable
+fun PreviewCustomButtonLocalised() {
+    CustomButton(
+        text = stringResource(id = R.string.button),
+        onClick = {  },
+        size = ButtonSize.Small
+    )
+}
+
 
 @Suppress("MatchingDeclarationName")
 enum class ButtonSize {

diff --git a/showkase-screenshot-testing-paparazzi-sample/src/main/res/values-nb-rNO/strings.xml b/showkase-screenshot-testing-paparazzi-sample/src/main/res/values-nb-rNO/strings.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="button">Knapp</string>
+</resources>
diff --git a/showkase-screenshot-testing-paparazzi-sample/src/main/res/values/strings.xml b/showkase-screenshot-testing-paparazzi-sample/src/main/res/values/strings.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="button">Button</string>
+</resources>
diff --git a/...android/showkase/screenshot/testing/paparazzi/sample/MyPaparazziShowkaseScreenshotTest.kt b/...android/showkase/screenshot/testing/paparazzi/sample/MyPaparazziShowkaseScreenshotTest.kt
@@ -1,9 +1,23 @@
 package com.airbnb.android.showkase.screenshot.testing.paparazzi.sample
 
+import app.cash.paparazzi.DeviceConfig
 import com.airbnb.android.showkase.annotation.ShowkaseScreenshot
+import com.airbnb.android.showkase.screenshot.testing.paparazzi.PaparazziShowkaseDeviceConfig
 import com.airbnb.android.showkase.screenshot.testing.paparazzi.PaparazziShowkaseScreenshotTest
 
 @ShowkaseScreenshot(rootShowkaseClass = PaparazziSampleRootModule::class)
-abstract class MyPaparazziShowkaseScreenshotTest: PaparazziShowkaseScreenshotTest {
-    companion object: PaparazziShowkaseScreenshotTest.CompanionObject
+abstract class MyPaparazziShowkaseScreenshotTest : PaparazziShowkaseScreenshotTest {
+    companion object : PaparazziShowkaseScreenshotTest.CompanionObject {
+        override fun deviceConfigs(): List<PaparazziShowkaseDeviceConfig> {
+            return listOf("en-rGB", "nb-rNO").map { locale ->
+                PaparazziShowkaseDeviceConfig(
+                    deviceConfig = DeviceConfig.PIXEL_5.copy(locale = locale)
+                )
+            }
+        }
+    }
+
+    override fun shouldTakeScreenshot(deviceConfig: DeviceConfig, group: String): Boolean {
+        return deviceConfig.locale == "en-rGB" || group == "Localised"
+    }
 }
diff --git a/...*CustomButton**Small,1.Pixel5,1.Ltr,1.DEFAULT]_buttons**custombutton**small.png b/...*CustomButton**Small,1.Pixel5,1.Ltr,1.DEFAULT]_buttons**custombutton**small.png
diff --git a/...ext Style**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**sans_serif_text_style**null.png b/...ext Style**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**sans_serif_text_style**null.png
diff --git a/...rif Text Style**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**serif_text_style**null.png b/...rif Text Style**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**serif_text_style**null.png
diff --git a/...[13.Rows**Simple Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_rows**simple_row**null.png b/...[13.Rows**Simple Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_rows**simple_row**null.png
diff --git a/...l**null,1.Pixel5,1.Ltr,1.DEFAULT]_rows**title_subtitle_with_thumbnail**null.png b/...l**null,1.Pixel5,1.Ltr,1.DEFAULT]_rows**title_subtitle_with_thumbnail**null.png
diff --git a/...al Scroll**null,1.Pixel5,1.Ltr,1.DEFAULT]_scrollable**vertical_scroll**null.png b/...al Scroll**null,1.Pixel5,1.Ltr,1.DEFAULT]_scrollable**vertical_scroll**null.png
diff --git a/...5.Text**H6 Text Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row**null.png b/...5.Text**H6 Text Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row**null.png
diff --git a/...ont**null,1.Pixel5,1.Ltr,1.DEFAULT]_default_group**preview_-_1.5_font**null.png b/...ont**null,1.Pixel5,1.Ltr,1.DEFAULT]_default_group**preview_-_1.5_font**null.png
diff --git a/...ars**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row_&_special_chars**null.png b/...ars**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row_&_special_chars**null.png
diff --git a/...7.Text**H6 Text Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row**null.png b/...7.Text**H6 Text Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row**null.png
diff --git a/...8.Text**H6 Text Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row**null.png b/...8.Text**H6 Text Row**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row**null.png
diff --git a/...ars**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row_&_special_chars**null.png b/...ars**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row_&_special_chars**null.png
diff --git a/...ws[20.Light Colors**Primary,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**primary.png b/...ws[20.Light Colors**Primary,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**primary.png
diff --git a/...ars**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row_&_special_chars**null.png b/...ars**null,1.Pixel5,1.Ltr,1.DEFAULT]_text**h6_text_row_&_special_chars**null.png
diff --git a/...rs**Primary Variant,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**primary_variant.png b/...rs**Primary Variant,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**primary_variant.png
diff --git a/...2.Light Colors**Secondary,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**secondary.png b/...2.Light Colors**Secondary,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**secondary.png
diff --git a/...Secondary Variant,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**secondary_variant.png b/...Secondary Variant,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**secondary_variant.png
diff --git a/...Light Colors**Background,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**background.png b/...Light Colors**Background,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**background.png
diff --git a/...ws[25.Light Colors**Surface,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**surface.png b/...ws[25.Light Colors**Surface,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**surface.png
diff --git a/...eviews[26.Light Colors**Error,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**error.png b/...eviews[26.Light Colors**Error,1.Pixel5,1.Ltr,1.DEFAULT]_light_colors**error.png
diff --git a/....Ltr,1.DEFAULT]_light_colors**primary.png → ....Ltr,1.DEFAULT]_light_colors**primary.png b/....Ltr,1.DEFAULT]_light_colors**primary.png → ....Ltr,1.DEFAULT]_light_colors**primary.png
diff --git a/...EFAULT]_light_colors**primary_variant.png → ...EFAULT]_light_colors**primary_variant.png b/...EFAULT]_light_colors**primary_variant.png → ...EFAULT]_light_colors**primary_variant.png
diff --git a/....Pixel5,1.Ltr,1.DEFAULT]_material**h1.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h1.png b/....Pixel5,1.Ltr,1.DEFAULT]_material**h1.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h1.png
diff --git a/....Pixel5,1.Ltr,1.DEFAULT]_material**h2.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h2.png b/....Pixel5,1.Ltr,1.DEFAULT]_material**h2.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h2.png
diff --git a/....Pixel5,1.Ltr,1.DEFAULT]_material**h3.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h3.png b/....Pixel5,1.Ltr,1.DEFAULT]_material**h3.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h3.png
diff --git a/....Pixel5,1.Ltr,1.DEFAULT]_material**h4.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h4.png b/....Pixel5,1.Ltr,1.DEFAULT]_material**h4.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h4.png
diff --git a/....Pixel5,1.Ltr,1.DEFAULT]_material**h5.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h5.png b/....Pixel5,1.Ltr,1.DEFAULT]_material**h5.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h5.png
diff --git a/....Pixel5,1.Ltr,1.DEFAULT]_material**h6.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h6.png b/....Pixel5,1.Ltr,1.DEFAULT]_material**h6.png → ....Pixel5,1.Ltr,1.DEFAULT]_material**h6.png
diff --git a/...,1.Ltr,1.DEFAULT]_material**subtitle1.png → ...,1.Ltr,1.DEFAULT]_material**subtitle1.png b/...,1.Ltr,1.DEFAULT]_material**subtitle1.png → ...,1.Ltr,1.DEFAULT]_material**subtitle1.png
diff --git a/...,1.Ltr,1.DEFAULT]_material**subtitle2.png → ...,1.Ltr,1.DEFAULT]_material**subtitle2.png b/...,1.Ltr,1.DEFAULT]_material**subtitle2.png → ...,1.Ltr,1.DEFAULT]_material**subtitle2.png
diff --git a/...xel5,1.Ltr,1.DEFAULT]_material**body1.png → ...xel5,1.Ltr,1.DEFAULT]_material**body1.png b/...xel5,1.Ltr,1.DEFAULT]_material**body1.png → ...xel5,1.Ltr,1.DEFAULT]_material**body1.png
diff --git a/...xel5,1.Ltr,1.DEFAULT]_material**body2.png → ...xel5,1.Ltr,1.DEFAULT]_material**body2.png b/...xel5,1.Ltr,1.DEFAULT]_material**body2.png → ...xel5,1.Ltr,1.DEFAULT]_material**body2.png
diff --git a/...el5,1.Ltr,1.DEFAULT]_material**button.png → ...el5,1.Ltr,1.DEFAULT]_material**button.png b/...el5,1.Ltr,1.DEFAULT]_material**button.png → ...el5,1.Ltr,1.DEFAULT]_material**button.png
diff --git a/...l5,1.Ltr,1.DEFAULT]_material**caption.png → ...l5,1.Ltr,1.DEFAULT]_material**caption.png b/...l5,1.Ltr,1.DEFAULT]_material**caption.png → ...l5,1.Ltr,1.DEFAULT]_material**caption.png
diff --git a/...5,1.Ltr,1.DEFAULT]_material**overline.png → ...5,1.Ltr,1.DEFAULT]_material**overline.png b/...5,1.Ltr,1.DEFAULT]_material**overline.png → ...5,1.Ltr,1.DEFAULT]_material**overline.png
diff --git a/...ustomButton**Small,1.Pixel5,1.Ltr,1.DEFAULT]_localised**custombutton**small.png b/...ustomButton**Small,1.Pixel5,1.Ltr,1.DEFAULT]_localised**custombutton**small.png
diff --git a/...ustomButton**Small,2.Pixel5,1.Ltr,1.DEFAULT]_localised**custombutton**small.png b/...ustomButton**Small,2.Pixel5,1.Ltr,1.DEFAULT]_localised**custombutton**small.png
diff --git a/...ustomButton**Medium,1.Pixel5,1.Ltr,1.DEFAULT]_buttons**custombutton**medium.png b/...ustomButton**Medium,1.Pixel5,1.Ltr,1.DEFAULT]_buttons**custombutton**medium.png
diff --git a/...m/airbnb/android/showkase/screenshot/testing/paparazzi/PaparazziShowkaseScreenshotTest.kt b/...m/airbnb/android/showkase/screenshot/testing/paparazzi/PaparazziShowkaseScreenshotTest.kt
@@ -95,6 +95,12 @@ interface PaparazziShowkaseScreenshotTest {
         fun uiModes(): List<PaparazziShowkaseUIMode> = listOf(PaparazziShowkaseUIMode.DEFAULT)
     }
 
+    /**
+     * Can be overridden to add logic to decide if a screenshot should be taken
+     * based on the device config and group.
+     */
+    fun shouldTakeScreenshot(deviceConfig: DeviceConfig, group: String) : Boolean = true
+
     fun takePaparazziSnapshot(
         paparazzi: Paparazzi,
         testPreview: PaparazziShowkaseTestPreview,
@@ -133,6 +139,8 @@ interface PaparazziShowkaseScreenshotTest {
 }
 
 interface PaparazziShowkaseTestPreview {
+    val group: String
+
     @Composable
     fun Content()
 }
@@ -142,9 +150,11 @@ private const val DELIM = "**"
 class ComponentPaparazziShowkaseTestPreview(
     private val showkaseBrowserComponent: ShowkaseBrowserComponent,
 ) : PaparazziShowkaseTestPreview {
+    override val group: String = showkaseBrowserComponent.group
 
     @Composable
     override fun Content() = showkaseBrowserComponent.component()
+
     override fun toString(): String =
         "${showkaseBrowserComponent.group}${DELIM}${showkaseBrowserComponent.componentName}${DELIM}" +
                 "${showkaseBrowserComponent.styleName}"
@@ -153,6 +163,8 @@ class ComponentPaparazziShowkaseTestPreview(
 class ColorPaparazziShowkaseTestPreview(
     private val showkaseBrowserColor: ShowkaseBrowserColor
 ) : PaparazziShowkaseTestPreview {
+    override val group: String = showkaseBrowserColor.colorGroup
+
     @Composable
     override fun Content() {
         Box(
@@ -170,6 +182,8 @@ class ColorPaparazziShowkaseTestPreview(
 class TypographyPaparazziShowkaseTestPreview(
     private val showkaseBrowserTypography: ShowkaseBrowserTypography
 ) : PaparazziShowkaseTestPreview {
+    override val group: String = showkaseBrowserTypography.typographyGroup
+
     @Composable
     override fun Content() {
         BasicText(