Update Showkase to latest version of Jetpack Compose Navigation #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
designedbyz
force-pushed
the
andy/FE-2940
branch
from
c2b4342
to
a425732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of Jetpack Compose navigation to the latest version, 2.7.6, and updates other dependencies as needed along the way as well. This is needed to avoid some odd behavior with navigation 2.6.0; notably if you use compose navigation 2.6.0 and Showkase in the same project, the browser will not navigate from the root screen to any of typography, color, or composables. This seems to be an issue with Navigation 2.6.0, as both navigation 2.7.x and navigation 2.5.x work just fine.
Other dependencies have been updated as needed as well, most notably perhaps was updating the compile SDK to version 34. This was required for navigation 2.7.x.
I've seen a few issues while running tests on the project that I could use some help solving. Specifically, the
entering_text_in_search_bar_filters_the_visible_componentsandentering_text_in_search_bar_filters_the_visible_groups_of_componentsare acting a bit weird detecting two nodes, even though I only see one visible node when debugging the tests. I'd appreciate some help with debugging this.