[eslint config][major][guide] Always require parens around arrow function arguments #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharmilajesupaul
force-pushed
the
shar--always-use-parens-for-arrow-functions
branch
2 times, most recently
from
0ca14dc
to
21ef5e4
Compare
|
Yeaaaah!! 🎉 :) |
|
Thanks - since this is a semver-major, I'm going to hold off on merging it until after #1834 is released. |
lencioni
approved these changes
Jul 10, 2018
ljharb
requested changes
Jul 10, 2018
lencioni
approved these changes
Jul 10, 2018
|
|
||
| > Why? Less visual clutter. | ||
| > Why? Minimizes diff churn when adding or removing arguments. |
sharmilajesupaul
force-pushed
the
shar--always-use-parens-for-arrow-functions
branch
from
21ef5e4
to
020bdde
Compare
ljharb
force-pushed
the
shar--always-use-parens-for-arrow-functions
branch
from
020bdde
to
cf6219d
Compare
|
Since #1834 is done now, can this be rebased and merged? |
ljharb
force-pushed
the
shar--always-use-parens-for-arrow-functions
branch
from
bb12bcd
to
95f33e7
Compare
j-f1
reviewed
Dec 6, 2018
ljharb
force-pushed
the
shar--always-use-parens-for-arrow-functions
branch
from
95f33e7
to
cf57435
Compare
ljharb
force-pushed
the
shar--always-use-parens-for-arrow-functions
branch
from
e1cef35
to
820745d
Compare
|
Sweeet. One more rule which I like and forced in my config, got merged. :) |
ljharb
added a commit
that referenced
this pull request
Aug 14, 2019
vunb
pushed a commit
to hsdt/javascript
that referenced
this pull request
Nov 27, 2019
|
Overriding this
I don't find this to be the case; there's still a diff on the same line, so doesn't really make any meaningful change to the diffs, but 👇 is still meaningful.
Glad that it makes some people happy though, and I don't mind overriding things if necessary :) |
eugene2candy
pushed a commit
to eugene2candy/javascript
that referenced
this pull request
Apr 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
guide + eslint config change to always require parens around arrow function arguments.