Add missing lifecyle methods to react/sort-comp #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jun 17, 2019
Hypnosphi
reviewed
Oct 3, 2019
| 'componentDidUpdate', | ||
| 'componentDidCatch', |
There was a problem hiding this comment.
Now it's present twice: here and two lines below. Is it intended, or just a side effect of two parallel PRs?
There was a problem hiding this comment.
oops, it's a side effect. i'll clean it up prior to release (or, a PR is helpful)
Hypnosphi
added a commit
to Hypnosphi/javascript
that referenced
this pull request
Oct 3, 2019
See airbnb#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb#2043 (comment))
ljharb
pushed a commit
to Hypnosphi/javascript
that referenced
this pull request
Oct 3, 2019
See airbnb#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb#2043 (comment))
ljharb
pushed a commit
to Hypnosphi/javascript
that referenced
this pull request
Oct 4, 2019
See airbnb#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb#2043 (comment))
vunb
pushed a commit
to hsdt/javascript
that referenced
this pull request
Nov 27, 2019
See airbnb#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb#2043 (comment))
rchrdw
pushed a commit
to rchrdw/javascript
that referenced
this pull request
Feb 18, 2021
See airbnb#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb#2043 (comment))
eugene2candy
pushed a commit
to eugene2candy/javascript
that referenced
this pull request
Apr 10, 2021
See airbnb#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb#2043 (comment))
passionSeven
added a commit
to passionSeven/javascript
that referenced
this pull request
Jan 27, 2023
See airbnb/javascript#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb/javascript#2043 (comment))
Binary-Ninja-007
pushed a commit
to Binary-Ninja-007/JavaScript_Style_Guide
that referenced
this pull request
Aug 13, 2023
See airbnb/javascript#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb/javascript#2043 (comment))
harry908nilson
pushed a commit
to marcolane/Javascriipt
that referenced
this pull request
Sep 1, 2023
See airbnb/javascript#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb/javascript#2043 (comment))
olehrab
pushed a commit
to olehrab/JavaScript
that referenced
this pull request
Sep 14, 2023
See airbnb/javascript#2043 (comment) I left the one before `cWU`, as in [defaults](airbnb/javascript#2043 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On react/sort-comp rule description it shows the default configuration for lifecycle methods and some of them were missing here. This PR just adds them.
Fixes #2040