Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eslint config] add componentDidCatch to lifecycle for react/sort-comp #2060

Merged
merged 1 commit into from
Aug 10, 2019
Merged

[eslint config] add componentDidCatch to lifecycle for react/sort-comp #2060

merged 1 commit into from
Aug 10, 2019

Conversation

rahilvora
Copy link

@rahilvora rahilvora commented Jul 22, 2019 •
edited by ljharb

Fixes #2040.

@rahilvora rahilvora mentioned this pull request Jul 22, 2019
Closed
@ljharb ljharb force-pushed the Add_componentDidCatch_lifecycle_method_2040 branch from b3df6af to 8c686ea Compare August 10, 2019 04:53
@ljharb ljharb merged commit 8c686ea into airbnb:master Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor: tighten rules to match guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add componentDidCatch to lifecycle for react/sort-comp
2 participants
@rahilvora @ljharb