Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static-variables to sort-comp rule #2109

Merged
merged 1 commit into from Oct 6, 2019
Merged

Add static-variables to sort-comp rule #2109

merged 1 commit into from Oct 6, 2019
+1 −0

Conversation

foglerek
Copy link
Contributor

@foglerek foglerek commented Oct 4, 2019 •
edited by ljharb

As requested here: #2107 , this adds the static-variables rule added in eslint-plugin-react@7.15.0 to the top of the sort-comp order configuration.

Closes #2107.

ljharb
ljharb approved these changes Oct 6, 2019
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a patch, because the guide doesn't allow class fields yet anyways.

@ljharb ljharb merged commit 3fb312f into airbnb:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: loosen/fix/document rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[eslint-config-airbnb] Update react/sort-comp rule to allow static variables
2 participants
@foglerek @ljharb