Valid 'no-cycle' value

[boeric]

With the just released eslint 7.3.0, the rule no-cycle's maxDepth value of Infinity is converted to null by eslint, which is invalid. This PR changes maxDepth from Infinity to Number.MAX_VALUE

[ljharb]

See #2249. This is a valid value; it’s a bug in eslint v7.3.0. Stick to eslint v7.2 for now.

[boeric]

Ok, thanks for quick reply. Wonder if there is some kind of JSON.parse(JSON.stringify()) going on in 7.3.0, as a JSON value of Infinity is stringified out as null. Ran out of time to debug 7.3.0. But this is going to be a problem for a lot of people until a fix is available. Also wonder about the quality of the test suite of eslint as eslint-config-airbnb is becoming a bit of a standard

[ljharb]

Yes, that’s the exact bug - see #2246, #2245, and eslint/eslint#13427

[boeric]

@ljharb Thanks for the links. Will be closing this. Also, posted this FYI: eslint/eslint#13427 (comment)

[ljharb]

No need to close it; i'll repurpose it if eslint doesn't fix this quickly.

[boeric]

Ok @ljharb, I'll leave it as is

[davidjbradshaw]

What's the objection to using Number.MAX_VALUE over Infinity? It has support all the way back to IE 4

[boeric]

Changed to Number.MAX_SAFE_INTEGER as per eslint/eslint#13427 (comment), and eslint/eslint#13435

[ljharb]

@boeric I'm not comfortable using that value. I'll force push this back to the final implementation, which will pass tests once eslint-plugin-import has a release.

[boeric]

@ljharb what is specifically wrong with Number.MAX_SAFE_INTEGER? Also don't understand what = does. Sorry if silly questions...

[ljharb]

It's not an equals sign, it's an infinity sign. The next release of eslint-plugin-import will treat ∞ the same as Infinity.

[boeric]

@ljharb I need to upgrade my eye glasses... I see what you're doing, thanks. I'll be closing this PR

[ljharb]

@boeric please leave it open; i'll be merging it once eslint-plugin-import is released.

[boeric]

@ljharb Ok