Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Lemlist: Make Connector Compatible with Builder #38119

Merged
merged 4 commits into from May 14, 2024
Merged

✨Source Lemlist: Make Connector Compatible with Builder #38119

merged 4 commits into from May 14, 2024

Conversation

btkcodedev
Copy link
Collaborator

@btkcodedev btkcodedev commented May 10, 2024 •
edited

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 10, 2024
@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:05am

@btkcodedev btkcodedev requested a review from girarda May 10, 2024 16:16
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/lemlist labels May 10, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 10, 2024 16:16
@btkcodedev btkcodedev changed the title ✨Source Lemlist: Make Compatible with Builder ✨Source Lemlist: Make Connector Compatible with Builder May 11, 2024
@btkcodedev
Copy link
Collaborator Author

CI is green, Ready to merge
image

@btkcodedev
Copy link
Collaborator Author

The auth scheme could be Basic auth with username as empty and password as api_key
OR we can pass api_key with access_token query param.
Builder doesn't support empty usernames, thus choosing the second method,

No breaking changes, all works the same ✅

@btkcodedev
Copy link
Collaborator Author

Removed $parameter macro ✅
Imported Schema ✅
GitHub CI Green ✅

girarda
girarda approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's first fix the date in the changelog, then 🚢

docs/integrations/sources/lemlist.md Outdated Show resolved Hide resolved
@btkcodedev @girarda
Update docs/integrations/sources/lemlist.md
2ce98a7 
Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
@btkcodedev
Copy link
Collaborator Author

@girarda Suggested change done

@girarda girarda merged commit 961d00a into master May 14, 2024
34 checks passed
@girarda girarda deleted the btkcodedev/lemlistCompatable branch May 14, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/lemlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btkcodedev @girarda @octavia-squidington-iii