Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

鉁⊿ource ExchangeRatesApi: Make Connector Compatible with Builder #38135

Merged
merged 8 commits into from May 22, 2024
Merged

鉁⊿ource ExchangeRatesApi: Make Connector Compatible with Builder #38135

merged 8 commits into from May 22, 2024

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 馃挌

@btkcodedev btkcodedev self-assigned this May 11, 2024
@vercel Vercel
Copy link

vercel bot commented May 11, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Visit Preview May 11, 2024 7:05am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 11, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 11, 2024 05:30
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented May 11, 2024 •
edited

Incremental sync was broken

@btkcodedev btkcodedev requested a review from girarda May 11, 2024 07:04
@btkcodedev
Copy link
Collaborator Author

btkcodedev commented May 11, 2024 •
edited

@girarda,
The latest version of this connector is also failing its incremental sync, What to do now?
Your call.
Ref:
image

@girarda
Copy link
Contributor

girarda commented May 22, 2024

/approve-and-merge reason="low-usage community connector. CATs are also failing on master"

@girarda
Copy link
Contributor

girarda commented May 22, 2024

/approve-and-merge reason="low-usage community connector. CATs are also failing on master"

@octavia-approvington
Copy link
Contributor

A crack team of mammals has made a decision.
imagine a seal of approval

@octavia-approvington octavia-approvington merged commit 851ef11 into master May 22, 2024
32 of 35 checks passed
@octavia-approvington octavia-approvington deleted the btkcodedev/exchangeRatesApiCompatable branch May 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

@octavia-approvington octavia-approvington octavia-approvington approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/exchange-rates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@btkcodedev @girarda @octavia-approvington @octavia-squidington-iii