Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source PokeApi: Make Connector Compatible with Builder #38136

Merged
merged 4 commits into from May 15, 2024
Merged

✨Source PokeApi: Make Connector Compatible with Builder #38136

merged 4 commits into from May 15, 2024
+2,754 −1,416

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 11, 2024
@vercel Vercel
Copy link

vercel bot commented May 11, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:57am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 11, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 11, 2024 06:10
@btkcodedev
Copy link
Collaborator Author

GitHub CI Green, Ready to merge ✅

image

@btkcodedev btkcodedev requested a review from girarda May 11, 2024 06:40
@btkcodedev
Copy link
Collaborator Author

Removed $parameter macro ✅
Migrated to Poetry flow, ✅
GitHub CI Green ✅

girarda
girarda approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@girarda girarda merged commit 0e76011 into master May 15, 2024
35 checks passed
@girarda girarda deleted the btkcodedev/pokeApiCompatable branch May 15, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pokeapi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btkcodedev @girarda @octavia-squidington-iii