Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Aha: Make Connector Compatible with Builder #38144

Merged
merged 7 commits into from May 14, 2024

Conversation

pabloescoder
Copy link
Collaborator

@pabloescoder pabloescoder commented May 11, 2024

What

Makes the connector compatible with the Builder UI

How

  • Use Poetry instead of requirements.txt & Dockerfile
  • Import schema to Inline Schema in manifest
  • Remove $parameters
  • Bump minor version
  • Make it compatible with the Builder

User Impact

Non impacting, done for maintainability

Can this PR be safely reverted and rolled back?

  • YES 💚

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 8:04pm

@pabloescoder
Copy link
Collaborator Author

I've received credentials for this connector, and I tried using those connectors to login to Aha, it shows that the trial period has expired so that's the reason why integration tests for this connector are failing (as the creds are expired). I'll work with Daniel to get them renewed, then we can move ahead with this PR.
image
image

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending updating the date in the changelog

docs/integrations/sources/aha.md Outdated Show resolved Hide resolved
Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
@pabloescoder
Copy link
Collaborator Author

@girarda Updated the date

@girarda girarda merged commit 13fc33f into master May 14, 2024
34 checks passed
@girarda girarda deleted the source-aha-make-builder-compatible branch May 14, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/aha
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants