Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Source Chartmogul: Make Connector Compatible with Builder #38145

Merged
merged 8 commits into from May 15, 2024

Conversation

pabloescoder
Copy link
Collaborator

What

Makes the connector compatible with the Builder UI

How

  • Use Poetry instead of requirements.txt & Dockerfile
  • Import schema to Inline Schema in manifest
  • Bump minor version
  • Make it compatible with the Builder

User Impact

Non impacting, done for maintainability

Can this PR be safely reverted and rolled back?

  • YES 💚

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 4:17am

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 12, 2024
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending updating the date in the changelog

@pabloescoder
Copy link
Collaborator Author

@girarda Updated the date in the changelog

@girarda girarda merged commit bce549a into master May 15, 2024
34 of 35 checks passed
@girarda girarda deleted the source-chartmogul-make-builder-compatible branch May 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chartmogul
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants