Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨Source Clockify: Make Connector Compatible with Builder #38146

Merged
merged 10 commits into from May 21, 2024
Merged

✨Source Clockify: Make Connector Compatible with Builder #38146

merged 10 commits into from May 21, 2024
+902 −756

Conversation

btkcodedev
Copy link
Collaborator

What

  • Make the connector compatible with the builder

How

  • Import schema to manifest
  • Update docs,
  • Completely made compatible with the builder

User Impact

  • No impact, chore for maintainability.

Can this PR be safely reverted and rolled back?

  • YES 💚

@btkcodedev btkcodedev self-assigned this May 12, 2024
@vercel Vercel
Copy link

vercel bot commented May 12, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 6:12pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels May 12, 2024
@octavia-squidington-iv octavia-squidington-iv requested review from a team May 12, 2024 05:58
@btkcodedev
Copy link
Collaborator Author

Removed $parameters macro ✅
Embed spec ✅

GitHub CI green ✅, Ready to merge
image

@btkcodedev @girarda
Update docs/integrations/sources/clockify.md
d4ea559 
Co-authored-by: Alexandre Girard <alexandre@airbyte.io>
@btkcodedev
Copy link
Collaborator Author

Change done

@octavia-squidington-iv octavia-squidington-iv requested a review from a team May 14, 2024 01:21
@btkcodedev btkcodedev requested a review from girarda May 15, 2024 12:30
@girarda girarda merged commit 18fb4c5 into master May 21, 2024
28 of 30 checks passed
@girarda girarda deleted the btkcodedev/clockifyCompatable branch May 21, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girarda girarda girarda approved these changes

Assignees

@btkcodedev btkcodedev

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/clockify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@btkcodedev @girarda @octavia-squidington-iii